qoherent/ria-toolkit-oss
19
6
Fork 0
Code Issues Pull Requests 1 Workflows Packages Projects Releases 6 Wiki Activity

viewfix #17

Merged
gillian merged 12 commits from viewfix into main 2026-02-02 11:02:59 -05:00
Conversation 0 Commits 12 Files Changed 19 +5 -6
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit f5209233d7 - Show all commits

11
src/ria_toolkit_oss/view/view_signal.py
View File

@ -114,8 +114,8 @@ def view_sig(
logo: Optional[bool] = True, logo: Optional[bool] = True,
dark: Optional[bool] = True, dark: Optional[bool] = True,
spines: Optional[bool] = False, spines: Optional[bool] = False,
title_fontsize: Optional[int] = 40, title_fontsize: Optional[int] = 35,
subtitle_fontsize: Optional[int] = 20, subtitle_fontsize: Optional[int] = 15,
) -> None: ) -> None:
""" """
Create a plot of various signal visualizations as a png or svg image. Create a plot of various signal visualizations as a png or svg image.
@ -173,7 +173,7 @@ def view_sig(
plot_length = len(recording.data[0]) plot_length = len(recording.data[0])
# Plot preparation # Plot preparation
fig = plt.figure(figsize=(14, 12)) fig = plt.figure(figsize=(16, 14))
fig.suptitle(title, fontsize=title_fontsize) fig.suptitle(title, fontsize=title_fontsize)
gs = gridspec.GridSpec(subplot_height, subplot_width) gs = gridspec.GridSpec(subplot_height, subplot_width)
@ -209,7 +209,7 @@ def view_sig(
) )
set_spines(spec_ax, spines) set_spines(spec_ax, spines)
spec_ax.set_title("Spectrogram", loc="center", fontsize=subtitle_fontsize) spec_ax.set_title("Spectrogram", fontsize=subtitle_fontsize)
M
madrigal commented 2026-01-29 16:24:47 -05:00
Review
Copy Link

Do the other set_titles in this file have loc="center"? It should be consistent among the subtitles

Do the other `set_titles` in this file have `loc="center"`? It should be consistent among the subtitles
M
madrigal commented 2026-01-30 17:33:52 -05:00
Review
Copy Link

Does seem to be consistent among subtitles

Does seem to be consistent among subtitles
spec_ax.set_ylabel("Frequency (Hz)") spec_ax.set_ylabel("Frequency (Hz)")
spec_ax.set_xlabel("Time (s)") spec_ax.set_xlabel("Time (s)")
@ -295,8 +295,7 @@ def view_sig(
set_spines(meta_ax, spines) set_spines(meta_ax, spines)
if logo and os.path.isfile(logo_path): if logo and os.path.isfile(logo_path):
logo_ax = plt.subplot(gs[plot_y_indx:, 2]) logo_ax = plt.subplot(gs[plot_y_indx + 2:, 2])
plot_x_indx = plot_x_indx + 1
logo_ax.axis("off") logo_ax.axis("off")
try: try: